Changeset 4046 for pjproject

Timestamp:

Apr 13, 2012 4:28:26 AM (13 years ago)

Author:

bennylp

Message:

Fixed #1487: Wrong SDP negotiator state if outgoing UPDATE or re-INVITE is challenged with 401 or 407

File:

• pjproject/branches/1.x/pjsip/src/pjsip-ua/sip_inv.c (modified) (14 diffs)

pjproject/branches/1.x/pjsip/src/pjsip-ua/sip_inv.c

@@ -156 +156 @@
     pjsip_inv_session   *inv;       /* The invite session                   */
     pj_bool_t            sdp_done;  /* SDP negotiation done for this tsx?   */
+    pj_bool_t            retrying;  /* Resend (e.g. due to 401/407)         */
     pj_str_t             done_tag;  /* To tag in RX response with answer    */
     pj_bool_t            done_early;/* Negotiation was done for early med?  */
@@ -2809 +2810 @@
             
         } else {
+            struct tsx_inv_data *tsx_inv_data;
+
+            tsx_inv_data = (struct tsx_inv_data*)tsx->mod_data[mod_inv.mod.id];
+            if (tsx_inv_data)
+                tsx_inv_data->retrying = PJ_TRUE;
+
             /* Re-send BYE. */
             status = pjsip_inv_send_msg(inv, tdata);
@@ -2921 +2928 @@
  * Handle incoming response to UAC UPDATE request.
  */
-static void inv_handle_update_response( pjsip_inv_session *inv,
-                                        pjsip_event *e)
+static pj_bool_t inv_handle_update_response( pjsip_inv_session *inv,
+                                             pjsip_event *e)
 {
     pjsip_transaction *tsx = e->body.tsx_state.tsx;
-    struct tsx_inv_data *tsx_inv_data = NULL;
+    struct tsx_inv_data *tsx_inv_data;
+    pj_bool_t handled = PJ_FALSE;
     pj_status_t status = -1;
+
+    tsx_inv_data = (struct tsx_inv_data*)tsx->mod_data[mod_inv.mod.id];
+    pj_assert(tsx_inv_data);
 
     /* Handle 401/407 challenge. */
@@ -2933 +2944 @@
     {
         pjsip_tx_data *tdata;
-        
+
         status = pjsip_auth_clt_reinit_req( &inv->dlg->auth_sess, 
                                             e->body.tsx_state.src.rdata,
@@ -2951 +2962 @@
             
         } else {
+            if (tsx_inv_data)
+                tsx_inv_data->retrying = PJ_TRUE;
+
             /* Re-send request. */
             status = pjsip_inv_send_msg(inv, tdata);
         }
+
+        handled = PJ_TRUE;
     }
 
@@ -2962 +2978 @@
         status = handle_timer_response(inv, e->body.tsx_state.src.rdata,
                                        PJ_FALSE);
+        handled = PJ_TRUE;
     }
 
@@ -2973 +2990 @@
         status = inv_check_sdp_in_incoming_msg(inv, tsx, 
                                              e->body.tsx_state.src.rdata);
+        handled = PJ_TRUE;
     }
     
@@ -2986 +3004 @@
             status = handle_timer_response(inv, e->body.tsx_state.src.rdata,
                                            PJ_FALSE);
-        }
-
-        tsx_inv_data = (struct tsx_inv_data*)tsx->mod_data[mod_inv.mod.id];
-        if (tsx_inv_data == NULL) {
-            tsx_inv_data=PJ_POOL_ZALLOC_T(tsx->pool, struct tsx_inv_data);
-            tsx_inv_data->inv = inv;
-            tsx->mod_data[mod_inv.mod.id] = tsx_inv_data;
-        }
-    }
-
-    /* Cancel the negotiation if we don't get successful negotiation by now */
+            handled = PJ_TRUE;
+        }
+    }
+
+    /* Cancel the negotiation if we don't get successful negotiation by now,
+     * unless it's authentication challenge and the request is being retried.
+     */
     if (pjmedia_sdp_neg_get_state(inv->neg) ==
                 PJMEDIA_SDP_NEG_STATE_LOCAL_OFFER &&
-        tsx_inv_data && tsx_inv_data->sdp_done == PJ_FALSE) 
+        tsx_inv_data && tsx_inv_data->sdp_done == PJ_FALSE &&
+        !tsx_inv_data->retrying)
     {
         pjmedia_sdp_neg_cancel_offer(inv->neg);
@@ -3006 +3021 @@
         tsx_inv_data->sdp_done = PJ_TRUE;
     }
+
+    return handled;
 }
 
@@ -3205 +3222 @@
               tsx->status_code == PJSIP_SC_PROXY_AUTHENTICATION_REQUIRED)) 
     {
-
         pjsip_tx_data *tdata;
         pj_status_t status;
@@ -3227 +3243 @@
             
         } else {
+            struct tsx_inv_data *tsx_inv_data;
+
+            tsx_inv_data = (struct tsx_inv_data*)tsx->mod_data[mod_inv.mod.id];
+            if (tsx_inv_data)
+                tsx_inv_data->retrying = PJ_TRUE;
+
             /* Re-send request. */
             status = pjsip_inv_send_msg(inv, tdata);
@@ -3903 +3925 @@
          * Handle response to outgoing UPDATE request.
          */
-        if (handle_uac_tsx_response(inv, e) == PJ_FALSE)
-            inv_handle_update_response(inv, e);
+        if (inv_handle_update_response(inv, e) == PJ_FALSE)
+            handle_uac_tsx_response(inv, e);
 
     } else if (tsx->role == PJSIP_ROLE_UAS &&
@@ -4260 +4282 @@
 
             pjmedia_sdp_neg_state neg_state;
+            struct tsx_inv_data *tsx_inv_data;
+
+            tsx_inv_data = (struct tsx_inv_data*)tsx->mod_data[mod_inv.mod.id];
 
             /* Outgoing INVITE transaction has failed, cancel SDP nego */
             neg_state = pjmedia_sdp_neg_get_state(inv->neg);
-            if (neg_state == PJMEDIA_SDP_NEG_STATE_LOCAL_OFFER) {
+            if (neg_state == PJMEDIA_SDP_NEG_STATE_LOCAL_OFFER &&
+                tsx_inv_data->retrying == PJ_FALSE)
+            {
                 pjmedia_sdp_neg_cancel_offer(inv->neg);
             }
@@ -4288 +4315 @@
          * Handle response to outgoing UPDATE request.
          */
-        if (handle_uac_tsx_response(inv, e) == PJ_FALSE)
-            inv_handle_update_response(inv, e);
+        if (inv_handle_update_response(inv, e) == PJ_FALSE)
+            handle_uac_tsx_response(inv, e);
 
     } else if (tsx->role == PJSIP_ROLE_UAS &&