Changeset 4028 for pjproject

Timestamp:

Apr 5, 2012 8:41:20 AM (13 years ago)

Author:

nanang

Message:

Misc (Re #1446): limit pjsua_vid_codec_get/set_param() search domain to only codecs with RTP packetizations.

File:

• pjproject/trunk/pjsip/src/pjsua-lib/pjsua_vid.c (modified) (4 diffs)

pjproject/trunk/pjsip/src/pjsua-lib/pjsua_vid.c

@@ -228 +228 @@
  */
 
+static pj_status_t find_codecs_with_rtp_packing(
+                                    const pj_str_t *codec_id,
+                                    unsigned *count,
+                                    const pjmedia_vid_codec_info *p_info[])
+{
+    const pjmedia_vid_codec_info *info[32];
+    unsigned i, j, count_ = PJ_ARRAY_SIZE(info);
+    pj_status_t status;
+    
+    status = pjmedia_vid_codec_mgr_find_codecs_by_id(NULL, codec_id,
+                                                     &count_, info, NULL);
+    if (status != PJ_SUCCESS)
+        return status;
+
+    for (i = 0, j = 0; i < count_ && j<*count; ++i) {
+        if ((info[i]->packings & PJMEDIA_VID_PACKING_PACKETS) == 0)
+            continue;
+        p_info[j++] = info[i];
+    }
+    *count = j;
+    return PJ_SUCCESS;
+}
+
 /*
  * Enum all supported video codecs in the system.
@@ -292 +315 @@
                                         pjmedia_vid_codec_param *param)
 {
-    const pj_str_t all = { NULL, 0 };
-    const pjmedia_vid_codec_info *info;
-    unsigned count = 1;
+    const pjmedia_vid_codec_info *info[2];
+    unsigned count = 2;
     pj_status_t status;
 
-    if (codec_id->slen==1 && *codec_id->ptr=='*')
-        codec_id = &all;
-
-    status = pjmedia_vid_codec_mgr_find_codecs_by_id(NULL, codec_id,
-                                                     &count, &info, NULL);
+    status = find_codecs_with_rtp_packing(codec_id, &count, info);
     if (status != PJ_SUCCESS)
         return status;
@@ -308 +326 @@
         return (count > 1? PJ_ETOOMANY : PJ_ENOTFOUND);
 
-    status = pjmedia_vid_codec_mgr_get_default_param(NULL, info, param);
+    status = pjmedia_vid_codec_mgr_get_default_param(NULL, info[0], param);
     return status;
 }
@@ -324 +342 @@
     pj_status_t status;
 
-    status = pjmedia_vid_codec_mgr_find_codecs_by_id(NULL, codec_id,
-                                                     &count, info, NULL);
+    status = find_codecs_with_rtp_packing(codec_id, &count, info);
     if (status != PJ_SUCCESS)
         return status;
 
-    /* Codec ID should be specific */
-    if (count > 1) {
-        pj_assert(!"Codec ID is not specific");
-        return PJ_ETOOMANY;
-    }
+    if (count != 1)
+        return (count > 1? PJ_ETOOMANY : PJ_ENOTFOUND);
 
     status = pjmedia_vid_codec_mgr_set_default_param(NULL, info[0], param);