Changeset 4008 for pjproject/trunk

Timestamp:

Apr 3, 2012 4:03:19 AM (13 years ago)

Author:

nanang

Message:

Re #1453: fixed memory leak in pjmedia_vid_codec_mgr_set_default_param() caused by unreleased old pool when the new codec param is not NULL (thanks Faba Aa for the report).

File:

• pjproject/trunk/pjmedia/src/pjmedia/vid_codec.c (modified) (1 diff)

pjproject/trunk/pjmedia/src/pjmedia/vid_codec.c

@@ -723 +723 @@
     /* Update codec default param */
     p->param = pjmedia_vid_codec_param_clone(pool, param);
-    if (!p)
+    if (!p->param)
         return PJ_EINVAL;
+
     codec_desc->def_param = p;
 
     pj_mutex_unlock(mgr->mutex);
+
+    /* Release old pool at the very end, as application tends to apply changes
+     * to the existing/old codec param fetched using
+     * pjmedia_vid_codec_mgr_get_default_param() which doesn't do deep clone.
+     */
+    if (old_pool)
+        pj_pool_release(old_pool);
 
     return PJ_SUCCESS;