Changeset 3989

Timestamp:

Mar 28, 2012 7:49:54 AM (13 years ago)

Author:

nanang

Message:

Fix #1470: Make sure the transaction layer module is unloaded when SIP endpoint is destroyed, by rescheduling the unload (using SIP endpoint atexit callback) after unload failure due to any pending/undestroyed transaction.

File:

• pjproject/branches/1.x/pjsip/src/pjsip/sip_transaction.c (modified) (2 diffs)

pjproject/branches/1.x/pjsip/src/pjsip/sip_transaction.c

@@ -715 +715 @@
 
     pj_mutex_unlock(mod_tsx_layer.mutex);
+
+    PJ_LOG(4,(THIS_FILE, "Stopped transaction layer module"));
+
     return PJ_SUCCESS;
+}
+
+
+/* Destroy this module */
+static void tsx_layer_destroy(pjsip_endpoint *endpt)
+{
+    PJ_UNUSED_ARG(endpt);
+
+    /* Destroy mutex. */
+    pj_mutex_destroy(mod_tsx_layer.mutex);
+
+    /* Release pool. */
+    pjsip_endpt_release_pool(mod_tsx_layer.endpt, mod_tsx_layer.pool);
+
+    /* Free TLS */
+    pj_thread_local_free(pjsip_tsx_lock_tls_id);
+
+    /* Mark as unregistered. */
+    mod_tsx_layer.endpt = NULL;
+
+    PJ_LOG(4,(THIS_FILE, "Transaction layer module destroyed"));
 }
 
@@ -730 +754 @@
      * from transport and when it tries to unregister itself.
      */
-    if (pj_hash_count(mod_tsx_layer.htable) != 0)
+    if (pj_hash_count(mod_tsx_layer.htable) != 0) {
+        if (pjsip_endpt_atexit(mod_tsx_layer.endpt, &tsx_layer_destroy) !=
+            PJ_SUCCESS)
+        {
+            PJ_LOG(3,(THIS_FILE, "Failed to register transaction layer "
+                                 "module destroy."));
+        }
         return PJ_EBUSY;
-
-    /* Destroy mutex. */
-    pj_mutex_destroy(mod_tsx_layer.mutex);
-
-    /* Release pool. */
-    pjsip_endpt_release_pool(mod_tsx_layer.endpt, mod_tsx_layer.pool);
-
-    /* Free TLS */
-    pj_thread_local_free(pjsip_tsx_lock_tls_id);
-
-    /* Mark as unregistered. */
-    mod_tsx_layer.endpt = NULL;
-
-    PJ_LOG(4,(THIS_FILE, "Transaction layer module destroyed"));
+    }
+
+    tsx_layer_destroy(mod_tsx_layer.endpt);
 
     return PJ_SUCCESS;