Changeset 3951

Timestamp:

Feb 8, 2012 9:29:38 AM (13 years ago)

Author:

nanang

Message:

Fix #1451: Don't hold the ICE session's mutex when calling pj_ice_sess_cb::on_tx_pkt() callback to avoid deadlock.

File:

• pjproject/branches/1.x/pjnath/src/pjnath/ice_session.c (modified) (3 diffs)

pjproject/branches/1.x/pjnath/src/pjnath/ice_session.c

@@ -2824 +2824 @@
     pj_ice_sess_comp *comp;
     pj_ice_sess_cand *cand;
+    pj_uint8_t transport_id;
+    pj_sockaddr addr;
 
     PJ_ASSERT_RETURN(ice && comp_id, PJ_EINVAL);
@@ -2839 +2841 @@
     if (comp == NULL) {
         status = PJNATH_EICEINCOMPID;
+        pj_mutex_unlock(ice->mutex);
         goto on_return;
     }
@@ -2844 +2847 @@
     if (comp->valid_check == NULL) {
         status = PJNATH_EICEINPROGRESS;
+        pj_mutex_unlock(ice->mutex);
         goto on_return;
     }
 
     cand = comp->valid_check->lcand;
-    status = (*ice->cb.on_tx_pkt)(ice, comp_id, cand->transport_id, 
+    transport_id = cand->transport_id;
+    pj_sockaddr_cp(&addr, &comp->valid_check->rcand->addr);
+
+    /* Release the mutex now to avoid deadlock (see ticket #1451). */
+    pj_mutex_unlock(ice->mutex);
+
+    status = (*ice->cb.on_tx_pkt)(ice, comp_id, transport_id, 
                                   data, data_len, 
-                                  &comp->valid_check->rcand->addr, 
+                                  &addr, 
                                   sizeof(pj_sockaddr_in));
 
 on_return:
-    pj_mutex_unlock(ice->mutex);
     return status;
 }