Changeset 3941

Timestamp:

Jan 12, 2012 6:09:08 AM (11 years ago)

Author:

nanang

Message:

Fix #1447: fix internal function write_frame() of the switchboard to copy the whole source frame to the destination port buffer if the destination port is port 0 (previously it only copied as much as samples-per-frame of port 0).

File:

• pjproject/branches/1.x/pjmedia/src/pjmedia/conf_switch.c (modified) (2 diffs)

pjproject/branches/1.x/pjmedia/src/pjmedia/conf_switch.c

@@ -1074 +1074 @@
             unsigned nsamples_to_copy, nsamples_req;
 
-            /* Copy frame to listener's TX buffer. */
+            /* Copy frame to listener's TX buffer.
+             * Note that if the destination is port 0, just copy the whole
+             * available samples.
+             */
             nsamples_to_copy = f_end - f_start;
             nsamples_req = cport_dst->info->samples_per_frame - 
                           (frm_dst->size>>1);
-            if (nsamples_to_copy > nsamples_req)
+            if (cport_dst->slot && nsamples_to_copy > nsamples_req)
                 nsamples_to_copy = nsamples_req;
 
@@ -1111 +1114 @@
             /* Check if it's time to deliver the TX buffer to listener, 
              * i.e: samples count in TX buffer equal to listener's
-             * samples per frame.
+             * samples per frame. Note that for destination port 0 this
+             * function will just populate all samples in the TX buffer.
              */
-            if ((frm_dst->size >> 1) == cport_dst->info->samples_per_frame)
+            if (cport_dst->slot == 0) {
+                /* Update TX timestamp. */
+                pj_add_timestamp32(&cport_dst->ts_tx, nsamples_to_copy);
+            } else if ((frm_dst->size >> 1) == 
+                       cport_dst->info->samples_per_frame)
             {
-                if (cport_dst->slot) {
-                    pjmedia_port_put_frame(cport_dst->port, frm_dst);
-
-                    /* Reset TX buffer. */
-                    frm_dst->size = 0;
-                }
+                pjmedia_port_put_frame(cport_dst->port, frm_dst);
+
+                /* Reset TX buffer. */
+                frm_dst->size = 0;
 
                 /* Update TX timestamp. */