Changeset 389

Timestamp:

Apr 5, 2006 10:05:04 PM (19 years ago)

Author:

bennylp

Message:

Protect RTCP packet lost calculation against incorrect packet expectations

Location:

pjproject/trunk

Files:

• pjmedia/src/pjmedia/rtcp.c (modified) (1 diff)
• pjsip-apps/src/samples/siprtp.c (modified) (1 diff)

pjproject/trunk/pjmedia/src/pjmedia/rtcp.c

@@ -262 +262 @@
     /* Total lost. */
     expected = pj_ntohl(rtcp_pkt->rr.last_seq) - s->seq_ctrl.base_seq;
-    u32 = expected - s->received;
+    if (expected >= s->received)
+        u32 = expected - s->received;
+    else
+        u32 = 0;
     rtcp_pkt->rr.total_lost_2 = (u32 >> 16) & 0x00FF;
     rtcp_pkt->rr.total_lost_1 = (u32 >> 8) & 0x00FF;

pjproject/trunk/pjsip-apps/src/samples/siprtp.c

@@ -1417 +1417 @@
 
     /* Print duration */
-    if (inv->state == PJSIP_INV_STATE_CONFIRMED) {
+    if (inv->state >= PJSIP_INV_STATE_CONFIRMED) {
         pj_time_val now;