Changeset 3149 for pjproject/trunk

Timestamp:

Apr 29, 2010 12:03:19 AM (15 years ago)

Author:

bennylp

Message:

Fixed #1061 (Assertion when receiving authentication challenge with empty realm (thanks Andrey Kovalenko for the report)):

• removed the assertion (allow responding to empty realm)
• slight modification in Authenticate/WWW-Authenticate headers to allow printing challenge with empty realm, otherwise a malformed header will be printed if empty realm is given

Location:

pjproject/trunk/pjsip/src/pjsip

Files:

• sip_auth_client.c (modified) (1 diff)
• sip_auth_msg.c (modified) (1 diff)

pjproject/trunk/pjsip/src/pjsip/sip_auth_client.c

@@ -394 +394 @@
 
         /* Save realm. */
+        /* Note: allow empty realm (http://trac.pjsip.org/repos/ticket/1061)
         pj_assert(cached_auth->realm.slen != 0);
+        */
         if (cached_auth->realm.slen == 0) {
             pj_strdup(ses_pool, &cached_auth->realm, 

pjproject/trunk/pjsip/src/pjsip/sip_auth_msg.c

@@ -233 +233 @@
     const pjsip_parser_const_t *pc = pjsip_parser_const();
 
-    copy_advance_pair_quote_cond(buf, " realm=", 7, chal->realm, '"', '"');
+    /* Allow empty realm, see http://trac.pjsip.org/repos/ticket/1061 */
+    copy_advance_pair_quote(buf, " realm=", 7, chal->realm, '"', '"');
     copy_advance_pair_quote_cond(buf, ",domain=", 8, chal->domain, '"', '"');
     copy_advance_pair_quote_cond(buf, ",nonce=", 7, chal->nonce, '"', '"');