Changeset 2926

Timestamp:

Oct 6, 2009 11:29:14 AM (15 years ago)

Author:

nanang

Message:

Ticket #964:

• Fixed creating media answer in SDP negotation to just clone the offer (and update media direction) when media offer specifies port 0 (media inactive).
• Added pjsua python test.

Location:

pjproject/trunk

Files:

• pjmedia/src/pjmedia/sdp_neg.c (modified) (2 diffs)
• tests/pjsua/scripts-sendto/126_sdp_with_port_0_and_no_rtpmap_for_dynamic_pt.py (added)

pjproject/trunk/pjmedia/src/pjmedia/sdp_neg.c

@@ -1007 +1007 @@
     pj_str_t pt_amr_need_adapt = {NULL, 0};
 
+    /* If offer has zero port, just clone the offer and update direction */
+    if (offer->desc.port == 0) {
+        answer = pjmedia_sdp_media_clone(pool, offer);
+        remove_all_media_directions(answer);
+        update_media_direction(pool, offer, answer);
+        *p_answer = answer;
+        return PJ_SUCCESS;
+    }
+
     /* Set master/slave negotiator based on prefer_remote_codec_order. */
     if (prefer_remote_codec_order) {
@@ -1219 +1228 @@
     answer->desc.fmt_count = pt_answer_count;
 
-    /* If offer has zero port, set our answer with zero port too */
-    if (offer->desc.port == 0)
-        answer->desc.port = 0;
-
     /* Update media direction. */
     update_media_direction(pool, offer, answer);