Changeset 2905 for pjproject/trunk/pjnath/src/pjnath/ice_session.c

Timestamp:

Aug 20, 2009 10:42:29 PM (15 years ago)

Author:

bennylp

Message:

Fixed ticket #953: ICE may find the wrong best candidate (thanks John Ridges for the report)

File:

• pjproject/trunk/pjnath/src/pjnath/ice_session.c (modified) (1 diff)

pjproject/trunk/pjnath/src/pjnath/ice_session.c

@@ -2314 +2314 @@
     }
 
-    /* Sort valid_list */
-    sort_checklist(&ice->valid_list);
-
     /* Update valid check and nominated check for the component */
     update_comp_check(ice, new_check->lcand->comp_id, new_check);
+
+    /* Sort valid_list (must do so after update_comp_check(), otherwise
+     * new_check will point to something else (#953)
+     */
+    sort_checklist(&ice->valid_list);
 
     /* 7.1.2.2.2.  Updating Pair States