Changeset 2726 for pjproject/trunk

Timestamp:

May 30, 2009 10:17:55 AM (15 years ago)

Author:

nanang

Message:

Ticket #862: Updated validations of SRTP crypto attribute.

File:

• pjproject/trunk/pjmedia/src/pjmedia/transport_srtp.c (modified) (3 diffs)

pjproject/trunk/pjmedia/src/pjmedia/transport_srtp.c

@@ -23 +23 @@
 #include <pjlib-util/base64.h>
 #include <pj/assert.h>
+#include <pj/ctype.h>
 #include <pj/lock.h>
 #include <pj/log.h>
@@ -981 +982 @@
     pj_str_t input;
     char *token;
+    int token_len;
     pj_str_t tmp;
     pj_status_t status;
@@ -994 +996 @@
         return PJMEDIA_SDP_EINATTR;
     }
+    token_len = pj_ansi_strlen(token);
+
+    /* Tag must not use leading zeroes. */
+    if (token_len > 1 && *token == '0')
+        return PJMEDIA_SDP_EINATTR;
+
+    /* Tag must be decimal, i.e: contains only digit '0'-'9'. */
+    for (itmp = 0; itmp < token_len; ++itmp)
+        if (!pj_isdigit(token[itmp]))
+            return PJMEDIA_SDP_EINATTR;
+
+    /* Get tag value. */
     *tag = atoi(token);
-    if (*tag == 0)
-        return PJMEDIA_SDP_EINATTR;
 
     /* Crypto-suite */