Changeset 2714 for pjproject

Timestamp:

May 18, 2009 11:49:46 PM (16 years ago)

Author:

bennylp

Message:

Ticket #856: Put back the ICE candidate priority values according to the default values in the draft-mmusic-ice

Location:

pjproject/branches/projects/sipit24/pjnath

Files:

• include/pjnath/config.h (modified) (2 diffs)
• src/pjnath/ice_session.c (modified) (4 diffs)
• src/pjnath/ice_strans.c (modified) (2 diffs)

pjproject/branches/projects/sipit24/pjnath/include/pjnath/config.h

@@ -260 +260 @@
 #define PJ_ICE_MAX_COMP             (2<<PJ_ICE_COMP_BITS)
 
+/**
+ * Use the priority value according to the ice-draft.
+ */
+#ifndef PJNATH_ICE_PRIO_STD
+#   define PJNATH_ICE_PRIO_STD                      1
+#endif
+
 
 /**
@@ -265 +272 @@
  */
 #ifndef PJ_ICE_CAND_TYPE_PREF_BITS
-#   define PJ_ICE_CAND_TYPE_PREF_BITS               2
+#   if PJNATH_ICE_PRIO_STD
+#       define PJ_ICE_CAND_TYPE_PREF_BITS           8
+#   else
+#       define PJ_ICE_CAND_TYPE_PREF_BITS           2
+#   endif
 #endif
 

pjproject/branches/projects/sipit24/pjnath/src/pjnath/ice_session.c

@@ -30 +30 @@
 #include <pj/string.h>
 
-
 /* String names for candidate types */
 static const char *cand_type_names[] =
@@ -243 +242 @@
                                     const pj_sockaddr *base_addr)
 {
-#if 0
+#if PJNATH_ICE_PRIO_STD
     char buf[64];
     pj_uint32_t val;
@@ -659 +658 @@
                                   pj_uint32_t comp_id)
 {
-#if 0
+#if PJNATH_ICE_PRIO_STD
     return ((ice->prefs[type] & 0xFF) << 24) + 
            ((local_pref & 0xFFFF)    << 8) +
@@ -1638 +1637 @@
 
     /* Add PRIORITY */
+#if PJNATH_ICE_PRIO_STD
+    prio = CALC_CAND_PRIO(ice, PJ_ICE_CAND_TYPE_PRFLX, 65535, 
+                          lcand->comp_id);
+#else
     prio = CALC_CAND_PRIO(ice, PJ_ICE_CAND_TYPE_PRFLX, 0, 
                           lcand->comp_id);
+#endif
     pj_stun_msg_add_uint_attr(check->tdata->pool, check->tdata->msg, 
                               PJ_STUN_ATTR_PRIORITY, prio);

pjproject/branches/projects/sipit24/pjnath/src/pjnath/ice_strans.c

@@ -51 +51 @@
  * specify preference among candidates with the same type. Since
  * we don't have the facility to specify that, we'll just set it
- * all to zero.
- */
-#define SRFLX_PREF  0
-#define HOST_PREF   0
-#define RELAY_PREF  0
+ * all to the same value.
+ */
+#if PJNATH_ICE_PRIO_STD
+#   define SRFLX_PREF  65535
+#   define HOST_PREF   65535
+#   define RELAY_PREF  65535
+#else
+#   define SRFLX_PREF  0
+#   define HOST_PREF   0
+#   define RELAY_PREF  0
+#endif
+
 
 /* The candidate type preference when STUN candidate is used */
 static pj_uint8_t srflx_pref_table[4] = 
 {
+#if PJNATH_ICE_PRIO_STD
+    100,    /**< PJ_ICE_HOST_PREF           */
+    126,    /**< PJ_ICE_SRFLX_PREF          */
+    110,    /**< PJ_ICE_PRFLX_PREF          */
+    0       /**< PJ_ICE_RELAYED_PREF    */
+#else
     /* Keep it to 2 bits */
     1,  /**< PJ_ICE_HOST_PREF       */
@@ -65 +78 @@
     3,  /**< PJ_ICE_PRFLX_PREF      */
     0   /**< PJ_ICE_RELAYED_PREF    */
+#endif
 };