Changeset 2650

Timestamp:

Apr 27, 2009 12:50:16 PM (15 years ago)

Author:

bennylp

Message:

Ticket #798: UAC disconnect call when receiving BYE in early state (thanks Gang Liu for the suggestion)

• UAC now handles the BYE, and treat it as out-of-order disconnect request, meaning that it will disconnect the call
• it will also activate timer to terminate the INVITE transaction, in case final response never arrives
• added SIPp UAS scenario to test this
• also added forked 200/OK response SIPp scenario,
• and fixed the prack_fork.xml SIPp scenario

Location:

pjproject/trunk

Files:

• pjsip-apps/src/pjsua/pjsua_app.c (modified) (2 diffs)
• pjsip/src/pjsip-ua/sip_inv.c (modified) (1 diff)
• tests/pjsua/scripts-sipp/prack_fork.xml (modified) (1 diff)
• tests/pjsua/scripts-sipp/uas-early-bye.xml (added)
• tests/pjsua/scripts-sipp/uas-forked-200.xml (added)

pjproject/trunk/pjsip-apps/src/pjsua/pjsua_app.c

@@ -3797 +3797 @@
             if (result.nb_result != NO_NB) {
 
-                if (result.nb_result == -1 || result.nb_result == 0) {
+                if (result.nb_result == -1) {
                     puts("Sorry you can't do that!");
                     continue;
+                } else if (result.nb_result == 0) {
+                    uri = NULL;
+                    if (current_call == PJSUA_INVALID_ID) {
+                        puts("No current call");
+                        continue;
+                    }
                 } else {
                     pjsua_buddy_info binfo;
@@ -3812 +3818 @@
             }
             
-            tmp = pj_str(uri);
-
-            send_request(text, &tmp);
+            if (uri) {
+                tmp = pj_str(uri);
+                send_request(text, &tmp);
+            } else {
+                /* If you send call control request using this method
+                 * (such requests includes BYE, CANCEL, etc.), it will
+                 * not go well with the call state, so don't do it
+                 * unless it's for testing.
+                 */
+                pj_str_t method = pj_str(text);
+                pjsua_call_send_request(current_call, &method, NULL);
+            }
             break;
 

pjproject/trunk/pjsip/src/pjsip-ua/sip_inv.c

@@ -3362 +3362 @@
         /* Generic handling for UAC tsx completion */
         handle_uac_tsx_response(inv, e);
+
+    } else if (tsx->role == PJSIP_ROLE_UAS &&
+               tsx->method.id == PJSIP_BYE_METHOD &&
+               tsx->status_code < 200 &&
+               e->body.tsx_state.type == PJSIP_EVENT_RX_MSG)
+    {
+        /* Received BYE before the 2xx/OK response to INVITE.
+         * Assume that the 2xx/OK response is lost and the BYE
+         * arrives earlier.
+         */
+        inv_respond_incoming_bye(inv, tsx, e->body.tsx_state.src.rdata, e);
+
+        /* Set timer just in case we will never get the final response
+         * for INVITE.
+         */
+        pjsip_tsx_set_timeout(inv->invite_tsx, 64*pjsip_cfg()->tsx.t1);
     }
 }

pjproject/trunk/tests/pjsua/scripts-sipp/prack_fork.xml

@@ -94 +94 @@
     <![CDATA[
       SIP/2.0 200 OK
-      Via: SIP/2.0/UDP [remote_ip]:[remote_port];rport=[remote_port];[$3]
+      Via: SIP/2.0/UDP 127.0.0.1:5080;received=127.0.0.1;rport=5080;[$3]
       [last_From:]
       [last_To:];tag=2