Changeset 2554 for pjproject/trunk/pjlib/src/pj/ioqueue_select.c

Timestamp:

Mar 26, 2009 11:16:06 AM (15 years ago)

Author:

bennylp

Message:

Ticket #769: Bug in select ioqueue: event counter may exceed maximum value, causing stack corruption (thanks Joel Dodson for the report)

File:

• pjproject/trunk/pjlib/src/pj/ioqueue_select.c (modified) (2 diffs)

pjproject/trunk/pjlib/src/pj/ioqueue_select.c

@@ -728 +728 @@
         /* Scan for readable socket. */
         if ((key_has_pending_read(h) || key_has_pending_accept(h))
-            && PJ_FD_ISSET(h->fd, &rfdset) && !IS_CLOSING(h))
+            && PJ_FD_ISSET(h->fd, &rfdset) && !IS_CLOSING(h) &&
+            counter<count)
         {
 #if PJ_IOQUEUE_HAS_SAFE_UNREG
@@ -740 +741 @@
 #if PJ_HAS_TCP
         if (key_has_pending_connect(h) && PJ_FD_ISSET(h->fd, &xfdset) &&
-            !IS_CLOSING(h)) 
+            !IS_CLOSING(h) && counter<count) 
         {
 #if PJ_IOQUEUE_HAS_SAFE_UNREG