Changeset 2497

Timestamp:

Mar 10, 2009 1:28:43 PM (16 years ago)

Author:

bennylp

Message:

Disable echo cancellation related setting from pjsua_aud_get/set_setting()

Location:

pjproject/branches/projects/aps-direct/pjsip

Files:

• include/pjsua-lib/pjsua.h (modified) (4 diffs)
• src/pjsua-lib/pjsua_media.c (modified) (1 diff)

pjproject/branches/projects/aps-direct/pjsip/include/pjsua-lib/pjsua.h

@@ -4906 +4906 @@
 
 /**
- * Change the echo cancellation settings. Application may also use the
- * #pjsua_snd_set_setting() to retrieve the echo cancellation setting.
+ * Change the echo cancellation settings.
  *
  * The behavior of this function depends on whether the sound device is
@@ -4940 +4939 @@
 
 /**
- * Get current echo canceller tail length. Application may also use the
- * #pjsua_snd_set_setting() to retrieve the echo cancellation setting.
+ * Get current echo canceller tail length. 
  *
  * @param p_tail_ms     Pointer to receive the tail length, in miliseconds. 
@@ -4980 +4978 @@
  * used.
  *
+ * Note also that the echo cancellation setting should be set with 
+ * #pjsua_set_ec() API instead.
+ *
  * See also #pjmedia_aud_stream_set_cap() for more information about setting
  * an audio device capability.
@@ -5003 +5004 @@
  * Otherwise, this function will return error.
  *
+ * Note that echo cancellation settings should be retrieved with 
+ * #pjsua_get_ec_tail() API instead.
+ *
  * @param cap           The sound device setting to retrieve.
  * @param pval          Pointer to receive the value. 

pjproject/branches/projects/aps-direct/pjsip/src/pjsua-lib/pjsua_media.c

@@ -77 +77 @@
                               PJMEDIA_AUD_DEV_CAP_INPUT_SIGNAL_METER |
                               PJMEDIA_AUD_DEV_CAP_OUTPUT_SIGNAL_METER);
+    /* EC settings use different API */
+    pjsua_var.aud_svmask &= ~(PJMEDIA_AUD_DEV_CAP_EC |
+                              PJMEDIA_AUD_DEV_CAP_EC_TAIL);
 
     /* Copy configuration */