Changeset 2484

Timestamp:

Mar 4, 2009 12:56:32 PM (15 years ago)

Author:

bennylp

Message:

Ticket #742: Change in mapped/STUN IP address does not update ICE srflx candidate (thanks Alexei Kuznetsov for the report)

Location:

pjproject/trunk/pjnath

Files:

• include/pjnath/stun_sock.h (modified) (1 diff)
• src/pjnath/ice_strans.c (modified) (3 diffs)
• src/pjnath/stun_sock.c (modified) (1 diff)

pjproject/trunk/pjnath/include/pjnath/stun_sock.h

@@ -74 +74 @@
      */
     PJ_STUN_SOCK_KEEP_ALIVE_OP,
+
+    /**
+     * IP address change notification from the keep-alive operation.
+     */
+    PJ_STUN_SOCK_MAPPED_ADDR_CHANGE
+
 
 } pj_stun_sock_op;

pjproject/trunk/pjnath/src/pjnath/ice_strans.c

@@ -1266 +1266 @@
         break;
     case PJ_STUN_SOCK_BINDING_OP:
+    case PJ_STUN_SOCK_MAPPED_ADDR_CHANGE:
         if (status == PJ_SUCCESS) {
             pj_stun_sock_info info;
@@ -1272 +1273 @@
             if (status == PJ_SUCCESS) {
                 char ipaddr[PJ_INET6_ADDRSTRLEN+10];
+                const char *op_name = (op==PJ_STUN_SOCK_BINDING_OP) ?
+                                    "Binding discovery complete" :
+                                    "srflx address changed";
                 pj_bool_t dup = PJ_FALSE;
 
@@ -1309 +1313 @@
 
                 PJ_LOG(4,(comp->ice_st->obj_name, 
-                          "Comp %d: Binding discovery complete, "
+                          "Comp %d: %s, "
                           "srflx address is %s",
-                          comp->comp_id, 
+                          comp->comp_id, op_name, 
                           pj_sockaddr_print(&info.mapped_addr, ipaddr, 
                                              sizeof(ipaddr), 3)));

pjproject/trunk/pjnath/src/pjnath/stun_sock.c

@@ -670 +670 @@
         pj_sockaddr_cp(&stun_sock->mapped_addr, &mapped_attr->sockaddr);
 
-        resched = (*stun_sock->cb.on_status)(stun_sock, op, PJ_SUCCESS);
-
-        goto on_return;
-    }
+        if (op==PJ_STUN_SOCK_KEEP_ALIVE_OP)
+            op = PJ_STUN_SOCK_MAPPED_ADDR_CHANGE;
+    }
+
+    /* Notify user */
+    resched = (*stun_sock->cb.on_status)(stun_sock, op, PJ_SUCCESS);
 
 on_return: