Changeset 2360

Timestamp:

Oct 31, 2008 4:26:27 PM (15 years ago)

Author:

bennylp

Message:

Ticket #673: Crash in SRTP transport when receiving stray RTP/RTCP packet

File:

• pjproject/trunk/pjmedia/src/pjmedia/transport_srtp.c (modified) (2 diffs)

pjproject/trunk/pjmedia/src/pjmedia/transport_srtp.c

@@ -799 +799 @@
 
     if (srtp->bypass_srtp) {
-        srtp->rtp_cb(srtp->user_data, pkt, size);
+        /* Callback may be NULL if we receive stray packets (or when packet
+         * is received while we're being detached/re-attached).
+         */
+        if (srtp->rtp_cb) {
+            srtp->rtp_cb(srtp->user_data, pkt, size);
+        }
         return;
     }
@@ -859 +864 @@
 
     if (srtp->bypass_srtp) {
+        /* Callback may be NULL if we receive stray packets (or when packet
+         * is received while we're being detached/re-attached).
+         */
         srtp->rtcp_cb(srtp->user_data, pkt, size);
         return;