Changeset 2294

Timestamp:

Sep 18, 2008 2:11:29 PM (16 years ago)

Author:

bennylp

Message:

More ticket #619: changed default Cordic loop from 8 to 10 to gain more accuracy, and updated tonegen.c with the results from ARM9 tests

Location:

pjproject/trunk/pjmedia

Files:

• include/pjmedia/config.h (modified) (2 diffs)
• src/pjmedia/tonegen.c (modified) (4 diffs)

pjproject/trunk/pjmedia/include/pjmedia/config.h

@@ -578 +578 @@
 
 /**
- * Specify the tone generator algorithm to be used.
+ * Specify the tone generator algorithm to be used. Please see 
+ * http://trac.pjsip.org/repos/wiki/Tone_Generator for the performance
+ * analysis results of the various tone generator algorithms.
  *
  * Default value:
@@ -601 +603 @@
  * Valid values are 1 to 28.
  *
- * Default value: 7
+ * Default value: 10
  */
 #ifndef PJMEDIA_TONEGEN_FIXED_POINT_CORDIC_LOOP
-#   define PJMEDIA_TONEGEN_FIXED_POINT_CORDIC_LOOP  7
+#   define PJMEDIA_TONEGEN_FIXED_POINT_CORDIC_LOOP  10
 #endif
 

pjproject/trunk/pjmedia/src/pjmedia/tonegen.c

@@ -41 +41 @@
      * Speed = 1347 usec to generate 1 second, 8KHz dual-tones (2.66GHz P4).
      *         approx. 10.91 MIPS
+     *
+     *         506,535 usec/100.29 MIPS on ARM926EJ-S.
      */
     struct gen
@@ -66 +68 @@
      * Speed = 350 usec to generate 1 second, 8KHz dual-tones (2.66GHz P4).
      *         approx. 2.84 MIPS
+     *
+     *         18,037 usec/3.57 MIPS on ARM926EJ-S.
      */
     struct gen
@@ -85 +89 @@
      *         (PJMEDIA_TONEGEN_FIXED_POINT_CORDIC_LOOP=7)
      *         approx. 6.01 MIPS
+     *
+     *         ARM926EJ-S results:
+     *          loop=7:   8,943 usec/1.77 MIPS
+     *          loop=8:   9,872 usec/1.95 MIPS
+     *          loop=10: 11,662 usec/2.31 MIPS
+     *          loop=12: 13,561 usec/2.69 MIPS
      */
     #define CORDIC_1K           0x026DD3B6
@@ -185 +195 @@
      * Speed = 117 usec to generate 1 second, 8KHz dual-tones (2.66GHz P4).
      *         approx. 0.95 MIPS
+     *
+     *         1,449 usec/0.29 MIPS on ARM926EJ-S.
      */
     PJ_INLINE(int) approximate_sin3(unsigned x)