Changeset 2265 for pjproject/trunk

Timestamp:

Sep 8, 2008 3:21:56 PM (16 years ago)

Author:

nanang

Message:

Fixed assertion caused by too small output buffer size of stream, this happens when codec with very small bandwidth is used, e.g: MELP 2.4kbps, (thanks William Wong).

File:

• pjproject/trunk/pjmedia/src/pjmedia/stream.c (modified) (2 diffs)

pjproject/trunk/pjmedia/src/pjmedia/stream.c

@@ -1378 +1378 @@
     pjmedia_channel *channel;
     pj_status_t status;
+    unsigned min_out_pkt_size;
     
     /* Allocate memory for channel descriptor */
@@ -1407 +1408 @@
     if (channel->out_pkt_size > PJMEDIA_MAX_MTU)
         channel->out_pkt_size = PJMEDIA_MAX_MTU;
+
+    /* It should big enough to hold (minimally) RTCP SR with an SDES. */
+    min_out_pkt_size =  sizeof(pjmedia_rtcp_sr_pkt) +
+                        sizeof(pjmedia_rtcp_common) +
+                        (4 + stream->cname.slen) +
+                        32;
+
+    if (channel->out_pkt_size < min_out_pkt_size)
+        channel->out_pkt_size = min_out_pkt_size;
 
     channel->out_pkt = pj_pool_alloc(pool, channel->out_pkt_size);