Changeset 2109

Timestamp:

Jul 7, 2008 8:00:10 PM (16 years ago)

Author:

bennylp

Message:

Related to ticket 554: handle the case where server rejects Authorization because of incorrect nonce but fails to set stale parameter to true. In this case we will retry the authentication as long as the nonce in the challenge is different than current nonce. This seems to have fixed ticket 554 too (to be confirmed)

File:

• pjproject/trunk/pjsip/src/pjsip/sip_auth_client.c (modified) (1 diff)

pjproject/trunk/pjsip/src/pjsip/sip_auth_client.c

@@ -942 +942 @@
      */
     if (hdr != &tdata->msg->hdr) {
-        if (hchal->challenge.digest.stale == 0) {
+        pj_bool_t stale;
+
+        /* Detect "stale" state */
+        stale = hchal->challenge.digest.stale;
+        if (!stale) {
+            /* If stale is false, check is nonce has changed. Some servers
+             * (broken ones!) want to change nonce but they fail to set
+             * stale to true.
+             */
+            stale = pj_strcmp(&hchal->challenge.digest.nonce,
+                              &sent_auth->credential.digest.nonce);
+        }
+
+        if (stale == PJ_FALSE) {
             /* Our credential is rejected. No point in trying to re-supply
              * the same credential.