Changeset 2006 for pjproject/trunk

Timestamp:

Jun 12, 2008 12:36:59 PM (16 years ago)

Author:

bennylp

Message:

Bug in srv_resolver: host_resolved value may exceed number of SRV records if there are more than A records in Additional Record section of the response for a single SRV target (thanks Ruud Klaver)

File:

• pjproject/trunk/pjlib-util/src/pjlib-util/srv_resolver.c (modified) (1 diff)

pjproject/trunk/pjlib-util/src/pjlib-util/srv_resolver.c

@@ -286 +286 @@
                 unsigned cnt = query_job->srv[j].addr_cnt;
                 query_job->srv[j].addr[cnt].s_addr = rr->rdata.a.ip_addr.s_addr;
+                /* Only increment host_resolved once per SRV record */
+                if (query_job->srv[j].addr_cnt == 0)
+                    ++query_job->host_resolved;
                 ++query_job->srv[j].addr_cnt;
-                ++query_job->host_resolved;
                 break;
             }