Changeset 1692


Ignore:
Timestamp:
Jan 14, 2008 6:35:51 PM (11 years ago)
Author:
bennylp
Message:

Related to ticket #449: fixed bug when rx volume adjustment caused static noise (thanks Norman Franke)

File:
1 edited

Legend:

Unmodified
Added
Removed
  • pjproject/trunk/pjmedia/src/pjmedia/conference.c

    r1691 r1692  
    14131413    cport->last_mix_adj = cport->mix_adj; 
    14141414 
    1415     adj_level = cport->tx_adj_level * cport->mix_adj / NORMAL_LEVEL; 
     1415    /* adj_level = cport->tx_adj_level * cport->mix_adj / NORMAL_LEVEL;*/ 
     1416    adj_level = cport->tx_adj_level * cport->mix_adj; 
     1417    adj_level >>= 7; 
     1418 
    14161419    tx_level = 0; 
    14171420 
     
    16771680                itemp = p_in[j]; 
    16781681                /*itemp = itemp * adj / NORMAL_LEVEL;*/ 
    1679                 itemp = (itemp * conf_port->rx_adj_level) >> 7; 
     1682                /* bad code (signed/unsigned badness): 
     1683                 *  itemp = (itemp * conf_port->rx_adj_level) >> 7; 
     1684                 */ 
     1685                itemp *= conf_port->rx_adj_level; 
     1686                itemp >>= 7; 
    16801687 
    16811688                /* Clip the signal if it's too loud */ 
Note: See TracChangeset for help on using the changeset viewer.