Changeset 1550

Timestamp:

Nov 5, 2007 11:14:18 PM (17 years ago)

Author:

bennylp

Message:

Update ticket #408: although route set must not be updated on subsequent requests, dialog MUST recompute the route set upon receiving 2xx response if the route set was previously computed from 1xx response

File:

• pjproject/trunk/pjsip/src/pjsip/sip_dialog.c (modified) (5 diffs)

pjproject/trunk/pjsip/src/pjsip/sip_dialog.c

@@ -643 +643 @@
         r = r->next;
     }
-    dlg->route_set_frozen = PJ_TRUE;
+    //dlg->route_set_frozen = PJ_TRUE;
 
     /* Clone client authentication session. */
@@ -1539 +1539 @@
 
 /* Update route-set from incoming message */
-static void dlg_update_routeset(pjsip_dialog *dlg, const pjsip_msg *msg)
+static void dlg_update_routeset(pjsip_dialog *dlg, const pjsip_rx_data *rdata)
 {
     const pjsip_hdr *hdr, *end_hdr;
-
-    /* Ignore if route set has been set */
+    pj_int32_t msg_cseq;
+    const pjsip_msg *msg;
+
+    msg = rdata->msg_info.msg;
+    msg_cseq = rdata->msg_info.cseq->cseq;
+
+    /* Ignore if route set has been frozen */
     if (dlg->route_set_frozen)
         return;
 
+    /* Only update route set if this message belongs to the same
+     * transaction as the initial transaction that establishes dialog.
+     */
+    if (dlg->role == PJSIP_ROLE_UAC) {
+
+        /* Ignore subsequent request from remote */
+        if (msg->type != PJSIP_RESPONSE_MSG)
+            return;
+
+        /* Ignore subsequent responses with higher CSeq than initial CSeq */
+        if (msg_cseq != dlg->local.first_cseq)
+            return;
+
+    } else {
+
+        /* For callee dialog, route set should have been set by initial
+         * request and it will have been rejected by dlg->route_set_frozen
+         * check above.
+         */
+        pj_assert(!"Should not happen");
+
+    }
+
+    /* Based on the checks above, we should only get response message here */
+    pj_assert(msg->type == PJSIP_RESPONSE_MSG);
+
+    /* Reset route set */
     pj_list_init(&dlg->route_set);
 
+    /* Update route set */
     end_hdr = &msg->hdr;
     for (hdr=msg->hdr.prev; hdr!=end_hdr; hdr=hdr->prev) {
@@ -1558 +1591 @@
         }
     }
-    dlg->route_set_frozen = PJ_TRUE;
-}
+
+    /* Freeze the route set only when the route set comes in 2xx response. 
+     * If it is in 1xx response, prepare to recompute the route set when 
+     * the 2xx response comes in.
+     *
+     * There is a debate whether route set should be frozen when the dialog
+     * is established with reliable provisional response, but I think
+     * it is safer to not freeze the route set (thus recompute the route set
+     * upon receiving 2xx response). Also RFC 3261 says so in 13.2.2.4.
+     */
+    if (PJSIP_IS_STATUS_IN_CLASS(msg->line.status.code, 200)) {
+        dlg->route_set_frozen = PJ_TRUE;
+    }
+}
+
 
 /* This function is called by user agent upon receiving incoming response
@@ -1619 +1665 @@
          * route set for future requests in this dialog.
          */
-        dlg_update_routeset(dlg, rdata->msg_info.msg);
+        dlg_update_routeset(dlg, rdata);
 
         /* The remote target MUST be set to the URI from the Contact header 
@@ -1679 +1725 @@
         }
 
-        dlg_update_routeset(dlg, rdata->msg_info.msg);
+        dlg_update_routeset(dlg, rdata);
     }