Changeset 1432


Ignore:
Timestamp:
Sep 12, 2007 5:25:15 PM (12 years ago)
Author:
bennylp
Message:

Ticket #349 revisited: Crash when sending PUBLISH when network is unreachable

File:
1 edited

Legend:

Unmodified
Added
Removed
  • pjproject/trunk/pjsip/src/pjsip-simple/publishc.c

    r1398 r1432  
    440440    }  
    441441     
    442     if (status != PJ_SUCCESS) { 
    443         char errmsg[PJ_ERR_MSG_SIZE]; 
    444         pj_str_t reason = pj_strerror(status, errmsg, sizeof(errmsg)); 
    445         call_callback(pubc, status, 400, &reason, NULL, -1); 
    446     } 
     442    // Callback should have been called. 
     443    // Calling it here will crash the system since pubc might have been 
     444    // destroyed 
     445    // 
     446    //if (status != PJ_SUCCESS) { 
     447    //  char errmsg[PJ_ERR_MSG_SIZE]; 
     448    //  pj_str_t reason = pj_strerror(status, errmsg, sizeof(errmsg)); 
     449    //  call_callback(pubc, status, 400, &reason, NULL, -1); 
     450    //} 
    447451} 
    448452 
     
    480484        }  
    481485         
    482         if (status != PJ_SUCCESS) { 
    483             call_callback(pubc, status, tsx->status_code,  
    484                           &rdata->msg_info.msg->line.status.reason, 
    485                           rdata, -1); 
    486         } 
     486        // Callback should have been called. 
     487        // Calling it here will crash the system since pubc might have been 
     488        // destroyed 
     489        // 
     490        //if (status != PJ_SUCCESS) { 
     491        //    call_callback(pubc, status, tsx->status_code,  
     492        //                &rdata->msg_info.msg->line.status.reason, 
     493        //                rdata, -1); 
     494        //} 
    487495 
    488496        return; 
Note: See TracChangeset for help on using the changeset viewer.