Changeset 1432

Timestamp:

Sep 12, 2007 5:25:15 PM (17 years ago)

Author:

bennylp

Message:

Ticket #349 revisited: Crash when sending PUBLISH when network is unreachable

File:

• pjproject/trunk/pjsip/src/pjsip-simple/publishc.c (modified) (2 diffs)

pjproject/trunk/pjsip/src/pjsip-simple/publishc.c

@@ -440 +440 @@
     } 
     
-    if (status != PJ_SUCCESS) {
-        char errmsg[PJ_ERR_MSG_SIZE];
-        pj_str_t reason = pj_strerror(status, errmsg, sizeof(errmsg));
-        call_callback(pubc, status, 400, &reason, NULL, -1);
-    }
+    // Callback should have been called.
+    // Calling it here will crash the system since pubc might have been
+    // destroyed
+    //
+    //if (status != PJ_SUCCESS) {
+    //  char errmsg[PJ_ERR_MSG_SIZE];
+    //  pj_str_t reason = pj_strerror(status, errmsg, sizeof(errmsg));
+    //  call_callback(pubc, status, 400, &reason, NULL, -1);
+    //}
 }
 
@@ -480 +484 @@
         } 
         
-        if (status != PJ_SUCCESS) {
-            call_callback(pubc, status, tsx->status_code, 
-                          &rdata->msg_info.msg->line.status.reason,
-                          rdata, -1);
-        }
+        // Callback should have been called.
+        // Calling it here will crash the system since pubc might have been
+        // destroyed
+        //
+        //if (status != PJ_SUCCESS) {
+        //    call_callback(pubc, status, tsx->status_code, 
+        //                &rdata->msg_info.msg->line.status.reason,
+        //                rdata, -1);
+        //}
 
         return;