Changeset 1393

Timestamp:

Jun 26, 2007 10:13:13 AM (17 years ago)

Author:

bennylp

Message:

Ticket #342: added option to disable RTCP advertisement in SDP (and ICE) to reduce SIP message size

Location:

pjproject/trunk

Files:

• pjmedia/include/pjmedia/config.h (modified) (2 diffs)
• pjsip/src/pjsua-lib/pjsua_media.c (modified) (1 diff)

pjproject/trunk/pjmedia/include/pjmedia/config.h

@@ -205 +205 @@
 
 /**
+ * Specify whether RTCP should be advertised in SDP. This setting would
+ * affect whether RTCP candidate will be added in SDP when ICE is used.
+ * Application might want to disable RTCP advertisement in SDP to
+ * reduce the message size.
+ *
+ * Default: 1 (yes)
+ */
+#ifndef PJMEDIA_ADVERTISE_RTCP
+#   define PJMEDIA_ADVERTISE_RTCP               1
+#endif
+
+
+/**
  * Interval to send RTCP packets, in msec
  */
@@ -344 +357 @@
 /**
  * Support for sending and decoding RTCP port in SDP (RFC 3605).
- * Default is yes.
+ * Default is equal to PJMEDIA_ADVERTISE_RTCP setting.
  */
 #ifndef PJMEDIA_HAS_RTCP_IN_SDP
-#   define PJMEDIA_HAS_RTCP_IN_SDP              1
+#   define PJMEDIA_HAS_RTCP_IN_SDP              (PJMEDIA_ADVERTISE_RTCP)
 #endif
 

pjproject/trunk/pjsip/src/pjsua-lib/pjsua_media.c

@@ -558 +558 @@
         pj_ice_strans_comp comp;
         int next_port;
-
-        status = pjmedia_ice_create(pjsua_var.med_endpt, NULL, 2,
+#if PJMEDIA_ADVERTISE_RTCP
+        enum { COMP_CNT=2 };
+#else
+        enum { COMP_CNT=1 };
+#endif
+
+        status = pjmedia_ice_create(pjsua_var.med_endpt, NULL, COMP_CNT,
                                     &pjsua_var.stun_cfg, 
                                     &pjsua_var.calls[i].med_tp);