Changeset 1289 for pjproject/trunk/pjnath/src/pjnath/stun_msg.c

Timestamp:

May 22, 2007 9:55:31 PM (17 years ago)

Author:

bennylp

Message:

Fixed ticket #286: Bug in STUN FINGERPRINT verification and logging STUN message

File:

• pjproject/trunk/pjnath/src/pjnath/stun_msg.c (modified) (2 diffs)

pjproject/trunk/pjnath/src/pjnath/stun_msg.c

@@ -1657 +1657 @@
 
         /* Check if FINGERPRINT attribute is present */
-        if (GETVAL16H(pdu, msg_len + 20) == PJ_STUN_ATTR_FINGERPRINT) {
-            pj_uint16_t attr_len = GETVAL16H(pdu, msg_len + 22);
-            pj_uint32_t fingerprint = GETVAL32H(pdu, msg_len + 24);
+        if (GETVAL16H(pdu, msg_len + 20 - 8) == PJ_STUN_ATTR_FINGERPRINT) {
+            pj_uint16_t attr_len = GETVAL16H(pdu, msg_len + 20 - 8 + 2);
+            pj_uint32_t fingerprint = GETVAL32H(pdu, msg_len + 20 - 8 + 4);
             pj_uint32_t crc;
 
@@ -1665 +1665 @@
                 return PJNATH_ESTUNINATTRLEN;
 
-            crc = pj_crc32_calc(pdu, msg_len + 20);
+            crc = pj_crc32_calc(pdu, msg_len + 20 - 8);
             crc ^= STUN_XOR_FINGERPRINT;