Changeset 122

Timestamp:

Jan 18, 2006 11:32:27 PM (19 years ago)

Author:

bennylp

Message:

Fixed minor warnings/mismatched comments mainly in pjlib++

Location:

pjproject/trunk/pjlib

Files:

• build/pjlib++.dsp (modified) (1 diff)
• include/pj++/file.hpp (modified) (1 diff)
• include/pj++/os.hpp (modified) (4 diffs)
• include/pj++/proactor.hpp (modified) (6 diffs)
• include/pj++/scanner.hpp (modified) (6 diffs)
• include/pj++/sock.hpp (modified) (2 diffs)
• include/pj++/string.hpp (modified) (2 diffs)
• include/pj++/timer.hpp (modified) (1 diff)
• include/pj/compat/cc_gcc.h (modified) (1 diff)
• include/pj/compat/cc_msvc.h (modified) (1 diff)
• include/pj/sock.h (modified) (1 diff)
• include/pjlib++.hpp (modified) (1 diff)

pjproject/trunk/pjlib/build/pjlib++.dsp

@@ -108 +108 @@
 # Begin Source File
 
+SOURCE="..\include\pjlib++.hpp"
+# End Source File
+# Begin Source File
+
 SOURCE="..\include\pj++\pool.hpp"
 # End Source File

pjproject/trunk/pjlib/include/pj++/file.hpp

@@ -84 +84 @@
     enum Offset_Type
     {
-        SEEK_SET = PJ_SEEK_SET,
-        SEEK_CUR = PJ_SEEK_CUR,
-        SEEK_END = PJ_SEEK_END,
+        PJ_SEEK_SET = PJ_SEEK_SET,
+        PJ_SEEK_CUR = PJ_SEEK_CUR,
+        PJ_SEEK_END = PJ_SEEK_END,
     };
 

pjproject/trunk/pjlib/include/pj++/os.hpp

@@ -21 +21 @@
 
 #include <pj/os.h>
+#include <pj/string.h>
 #include <pj++/types.hpp>
 #include <pj++/pool.hpp>
@@ -152 +153 @@
         destroy();
         return Pj_Thread_API::create( pool, &thread_, &thread_proc, this,
-                                      flags, thread_name);
+                                      flags, thread_name, stack_size);
     }
 
@@ -532 +533 @@
     : sem_(NULL)
     {
+        create(pool, max, initial, name);
     }
 
@@ -723 +725 @@
 
 //
+// Timestamp
+//
+class Pj_Timestamp
+{
+public:
+    pj_status_t get_timestamp()
+    {
+        return pj_get_timestamp(&ts_);
+    }
+
+    Pj_Timestamp& operator += (const Pj_Timestamp &rhs)
+    {
+        pj_add_timestamp(&ts_, &rhs.ts_);
+        return *this;
+    }
+
+    Pj_Timestamp& operator -= (const Pj_Timestamp &rhs)
+    {
+        pj_sub_timestamp(&ts_, &rhs.ts_);
+        return *this;
+    }
+
+    Pj_Time_Val to_time() const
+    {
+        Pj_Timestamp zero;
+        pj_memset(&zero, 0, sizeof(zero));
+        return Pj_Time_Val(pj_elapsed_time(&zero.ts_, &ts_));
+    }
+
+    pj_uint32_t to_msec() const
+    {
+        Pj_Timestamp zero;
+        pj_memset(&zero, 0, sizeof(zero));
+        return pj_elapsed_msec(&zero.ts_, &ts_);
+    }
+
+    pj_uint32_t to_usec() const
+    {
+        Pj_Timestamp zero;
+        pj_memset(&zero, 0, sizeof(zero));
+        return pj_elapsed_usec(&zero.ts_, &ts_);
+    }
+
+    pj_uint32_t to_nanosec() const
+    {
+        Pj_Timestamp zero;
+        pj_memset(&zero, 0, sizeof(zero));
+        return pj_elapsed_nanosec(&zero.ts_, &ts_);
+    }
+
+    pj_uint32_t to_cycle() const
+    {
+        Pj_Timestamp zero;
+        pj_memset(&zero, 0, sizeof(zero));
+        return pj_elapsed_cycle(&zero.ts_, &ts_);
+    }
+
+private:
+    pj_timestamp    ts_;
+};
+
+
+//
 // OS abstraction.
 //

pjproject/trunk/pjlib/include/pj++/proactor.hpp

@@ -207 +207 @@
     // Timeout callback.
     //
-    virtual void on_timeout(int data) 
+    virtual void on_timeout(int) 
     {
     }
@@ -214 +214 @@
     // On read complete callback.
     //
-    virtual void on_read_complete( Pj_Async_Op *op_key,
-                                   pj_ssize_t bytes_read) 
+    virtual void on_read_complete( Pj_Async_Op*, pj_ssize_t) 
     {
     }
@@ -222 +221 @@
     // On write complete callback.
     //
-    virtual void on_write_complete( Pj_Async_Op *op_key, 
-                                    pj_ssize_t bytes_sent) 
+    virtual void on_write_complete( Pj_Async_Op *, pj_ssize_t) 
     {
     }
@@ -231 +229 @@
     // On connect complete callback.
     //
-    virtual void on_connect_complete(pj_status_t status) 
+    virtual void on_connect_complete(pj_status_t) 
     {
     }
@@ -238 +236 @@
     // On new connection callback.
     //
-    virtual void on_accept_complete( Pj_Async_Op *op_key,
-                                     pj_sock_t new_sock,
-                                     pj_status_t status) 
+    virtual void on_accept_complete( Pj_Async_Op*, pj_sock_t, pj_status_t) 
     {
     }
@@ -257 +253 @@
     // Static timer callback.
     //
-    static void timer_callback( pj_timer_heap_t *timer_heap, 
+    static void timer_callback( pj_timer_heap_t*, 
                                 struct pj_timer_entry *entry)
     {

pjproject/trunk/pjlib/include/pj++/scanner.hpp

@@ -23 +23 @@
 #include <pj++/string.hpp>
 
-class Pj_Char_Spec
+class Pj_Cis;
+class Pj_Cis_Buffer;
+class Pj_Scanner;
+
+class Pj_Cis_Buffer
 {
+    friend class Pj_Cis;
+
 public:
-    Pj_Char_Spec() { pj_cs_init(cs__); }
-
-    void set(int c) { pj_cs_set(cs__, c); }
-    void add_range(int begin, int end) { pj_cs_add_range(cs__, begin, end); }
-    void add_alpha() { pj_cs_add_alpha(cs__); }
-    void add_num() { pj_cs_add_num(cs__); }
-    void add_str(const char *str) { pj_cs_add_str(cs__, str); }
-    void del_range(int begin, int end) { pj_cs_del_range(cs__, begin, end); }
-    void del_str(const char *str) { pj_cs_del_str(cs__, str); }
-    void invert() { pj_cs_invert(cs__); }
-    int  match(int c) { return pj_cs_match(cs__, c); }
-
-    pj_char_spec_element_t *cs_()
-    {
-        return cs__;
-    }
-
-    const pj_char_spec_element_t *cs_() const
-    {
-        return cs__;
+    Pj_Cis_Buffer() 
+    { 
+        pj_cis_buf_init(&buf_); 
     }
 
 private:
-    pj_char_spec cs__;
+    pj_cis_buf_t buf_;
 };
+
+
+class Pj_Cis
+{
+    friend class Pj_Scanner;
+
+public:
+    Pj_Cis(Pj_Cis_Buffer *buf)
+    {
+        pj_cis_init(&buf->buf_, &cis_);
+    }
+
+    Pj_Cis(const Pj_Cis &rhs)
+    {
+        pj_cis_dup(&cis_, (pj_cis_t*)&rhs.cis_);
+    }
+
+    void add_range(int start, int end)
+    {
+        pj_cis_add_range(&cis_, start, end);
+    }
+
+    void add_alpha()
+    {
+        pj_cis_add_alpha(&cis_);
+    }
+
+    void add_num()
+    {
+        pj_cis_add_num(&cis_);
+    }
+
+    void add_str(const char *str)
+    {
+        pj_cis_add_str(&cis_, str);
+    }
+
+    void add_cis(const Pj_Cis &rhs)
+    {
+        pj_cis_add_cis(&cis_, &rhs.cis_);
+    }
+
+    void del_range(int start, int end)
+    {
+        pj_cis_del_range(&cis_, start, end);
+    }
+
+    void del_str(const char *str)
+    {
+        pj_cis_del_str(&cis_, str);
+    }
+
+    void invert()
+    {
+        pj_cis_invert(&cis_);
+    }
+
+    bool match(int c) const
+    {
+        return pj_cis_match(&cis_, c) != 0;
+    }
+
+private:
+    pj_cis_t cis_;
+};
+
+
 
 class Pj_Scanner
@@ -86 +142 @@
     }
 
-    int peek(const Pj_Char_Spec *cs, Pj_String *out)
-    {
-        return pj_scan_peek(&scanner_,  cs->cs_(), out);
+    int peek(const Pj_Cis *cis, Pj_String *out)
+    {
+        return pj_scan_peek(&scanner_,  &cis->cis_, out);
     }
 
@@ -96 +152 @@
     }
 
-    int peek_until(const Pj_Char_Spec *cs, Pj_String *out)
-    {
-        return pj_scan_peek_until(&scanner_, cs->cs_(), out);
-    }
-
-    void get(const Pj_Char_Spec *cs, Pj_String *out)
-    {
-        pj_scan_get(&scanner_, cs->cs_(), out);
+    int peek_until(const Pj_Cis *cis, Pj_String *out)
+    {
+        return pj_scan_peek_until(&scanner_, &cis->cis_, out);
+    }
+
+    void get(const Pj_Cis *cis, Pj_String *out)
+    {
+        pj_scan_get(&scanner_, &cis->cis_, out);
     }
 
@@ -126 +182 @@
     }
 
-    void get_until(const Pj_Char_Spec *cs, Pj_String *out)
-    {
-        pj_scan_get_until(&scanner_, cs->cs_(), out);
+    void get_until(const Pj_Cis *cis, Pj_String *out)
+    {
+        pj_scan_get_until(&scanner_, &cis->cis_, out);
     }
 
@@ -161 +217 @@
     }
 
-    void save_state(State *state)
+    void save_state(State *state) const
     {
         pj_scan_save_state(&scanner_, state);
@@ -178 +234 @@
     int get_pos_col() const
     {
-        return scanner_.col;
+        return pj_scan_get_col(&scanner_);
     }
 

pjproject/trunk/pjlib/include/pj++/sock.hpp

@@ -236 +236 @@
     // getsockopt.
     //
-    pj_status_t getsockopt(int level, int optname, 
+    pj_status_t getsockopt(pj_uint16_t level, pj_uint16_t optname, 
                            void *optval, int *optlen)
     {
@@ -245 +245 @@
     // setsockopt
     // 
-    pj_status_t setsockopt(int level, int optname, 
+    pj_status_t setsockopt(pj_uint16_t level, pj_uint16_t optname, 
                            const void *optval, int optlen)
     {

pjproject/trunk/pjlib/include/pj++/string.hpp

@@ -345 +345 @@
 
     //
+    // Assign from char*
+    //
+    Pj_String& operator=(char *s)
+    {
+        set(s);
+        return *this;
+    }
+
+    ///
+    // Assign from another Pj_String
+    //
+    Pj_String& operator=(Pj_String &rhs)
+    {
+        set(rhs);
+        return *this;
+    }
+
+    //
     // Find a character in the string.
     //
@@ -416 +434 @@
     }
 
-
-private:
-    //Pj_String(const Pj_String &rhs) {}
-    void operator=(const Pj_String &rhs) { pj_assert(false); }
 };
 

pjproject/trunk/pjlib/include/pj++/timer.hpp

@@ -63 +63 @@
     pj_timer_entry entry_;
 
-    static void timer_heap_callback(pj_timer_heap_t *th, pj_timer_entry *e)
+    static void timer_heap_callback(pj_timer_heap_t*, pj_timer_entry *e)
     {
         Pj_Timer_Entry *entry = (Pj_Timer_Entry*) e->user_data;

pjproject/trunk/pjlib/include/pj/compat/cc_gcc.h

@@ -45 +45 @@
 typedef unsigned long long pj_uint64_t;
 
+#define PJ_INT64_FMT            "L"
+
 
 #endif  /* __PJ_COMPAT_CC_GCC_H__ */

pjproject/trunk/pjlib/include/pj/compat/cc_msvc.h

@@ -58 +58 @@
 typedef unsigned __int64 pj_uint64_t;
 
+#define PJ_INT64_FMT    "I64"
+
+
 #endif  /* __PJ_COMPAT_CC_MSVC_H__ */

pjproject/trunk/pjlib/include/pj/sock.h

@@ -664 +664 @@
  * @param tolen         The length of the address in bytes.
  *
- * @return              The length of data successfully sent.
+ * @return              PJ_SUCCESS or the status code.
  */
 PJ_DECL(pj_status_t) pj_sock_sendto(pj_sock_t sockfd,

pjproject/trunk/pjlib/include/pjlib++.hpp

@@ -20 +20 @@
 #define __PJLIBPP_H__
 
+#include <pj++/file.hpp>
 #include <pj++/pool.hpp>
 #include <pj++/hash.hpp>