Changeset 115

Timestamp:

Jan 8, 2006 11:56:17 PM (18 years ago)

Author:

bennylp

Message:

Transaction only decrements tx_data in send_msg() if return status is PJ_SUCCESS

Location:

pjproject/trunk/pjsip

Files:

• include/pjsip/sip_transaction.h (modified) (1 diff)
• src/pjsip/sip_transaction.c (modified) (1 diff)

pjproject/trunk/pjsip/include/pjsip/sip_transaction.h

@@ -191 +191 @@
 /**
  * Transmit message in tdata with this transaction. It is possible to
- * pass NULL in tdata for UAC transaction, which in this case the last message
- * or the request message which was specified in #pjsip_tsx_create_uac() 
- * will be sent.
- *
- * This function decrements the reference counter of the transmit buffer.
+ * pass NULL in tdata for UAC transaction, which in this case the last 
+ * message transmitted, or the request message which was specified when
+ * calling #pjsip_tsx_create_uac(), will be sent.
+ *
+ * This function decrements the reference counter of the transmit buffer
+ * only when it returns PJ_SUCCESS;
  *
  * @param tsx       The transaction.

pjproject/trunk/pjsip/src/pjsip/sip_transaction.c

@@ -1227 +1227 @@
      * (consistent with other send functions.
      */
-    pjsip_tx_data_dec_ref(tdata);
+    if (status == PJ_SUCCESS) {
+        pjsip_tx_data_dec_ref(tdata);
+    }
 
     return status;