Opened 16 years ago

Last modified 16 years ago

#619 closed defect

Bad tone quality generated by the tone generator when floating point is disabled (thanks Olle Frimanson for the report) — at Version 1

Reported by: bennylp Owned by: nanang
Priority: normal Milestone: release-1.0-rc3
Component: pjmedia Version: trunk
Keywords: Cc:
Backport to 1.x milestone: Backported:

Description (last modified by bennylp)

Issues with the tone generator:

  1. The sine approximation algorithm especially for the fixed point version is not good enough, causing aliasing frequencies to occur
  2. The volume perhaps can be made louder
  3. The volume is different between float and fixed point version
  4. The tonegen should attempt to create a full period of wave signal, slightly truncating or appending some samples as necessary.

Change History (1)

comment:1 Changed 16 years ago by bennylp

  • Description modified (diff)

In r2281:

  • Added PJMEDIA_TONEGEN_FORCE_FLOAT to force the tone generator to use floating point calculation even when floating point is disabled, to improve the tone quality.
  • Added PJMEDIA_TONEGEN_FADE_IN_TIME and PJMEDIA_TONEGEN_FADE_OUT_TIME to control tone fade-in and fade-out feature. Default value is 1 msec and 2 msec respectively.
Note: See TracTickets for help on using tickets.