Changeset 777

Timestamp:

Oct 16, 2006 9:07:19 PM (18 years ago)

Author:

bennylp

Message:

FIXED BUG: pjsip_endpt_send_request() SHOULD DELETE THE REQUEST REGARDLESS OF THE STATUS!!!

Location:

pjproject/trunk

Files:

• pjsip-apps/src/pjsua/pjsua_app.c (modified) (1 diff)
• pjsip-apps/src/samples/pjsip-perf.c (modified) (1 diff)
• pjsip/src/pjsip/sip_util_statefull.c (modified) (1 diff)

pjproject/trunk/pjsip-apps/src/pjsua/pjsua_app.c

@@ -1763 +1763 @@
     if (status != PJ_SUCCESS) {
         pjsua_perror(THIS_FILE, "Unable to send request", status);
-        pjsip_tx_data_dec_ref(tdata);
         return;
     }

pjproject/trunk/pjsip-apps/src/samples/pjsip-perf.c

@@ -1403 +1403 @@
         //should have been reported by tsx_completion_cb().
         //report_completion(701);
-        pjsip_tx_data_dec_ref(tdata);
+        //No longer necessary (r777)
+        //pjsip_tx_data_dec_ref(tdata);
     }
     return status;

pjproject/trunk/pjsip/src/pjsip/sip_util_statefull.c

@@ -107 +107 @@
     PJ_TODO(IMPLEMENT_TIMEOUT_FOR_SEND_REQUEST);
 
-    return pjsip_tsx_send_msg(tsx, NULL);
+    status = pjsip_tsx_send_msg(tsx, NULL);
+    if (status != PJ_SUCCESS)
+        pjsip_tx_data_dec_ref(tdata);
+
+    return status;
 }