Changeset 1912

Timestamp:

Apr 8, 2008 11:33:15 PM (16 years ago)

Author:

bennylp

Message:

As per list report, changed the default response to incoming REFER from 200 to 202 as some gateways do not like this. Thanks Pedro Sanchez for the report

Location:

pjproject/trunk/pjsip

Files:

• include/pjsua-lib/pjsua.h (modified) (1 diff)
• src/pjsua-lib/pjsua_call.c (modified) (6 diffs)

pjproject/trunk/pjsip/include/pjsua-lib/pjsua.h

@@ -661 +661 @@
      * Notify application on call being transfered (i.e. REFER is received).
      * Application can decide to accept/reject transfer request
-     * by setting the code (default is 200). When this callback
+     * by setting the code (default is 202). When this callback
      * is not defined, the default behavior is to accept the
      * transfer.

pjproject/trunk/pjsip/src/pjsua-lib/pjsua_call.c

@@ -3006 +3006 @@
 
     /* Notify callback */
-    code = PJSIP_SC_OK;
+    code = PJSIP_SC_ACCEPTED;
     if (pjsua_var.ua_cfg.cb.on_call_transfer_request)
         (*pjsua_var.ua_cfg.cb.on_call_transfer_request)(existing_call->index,
@@ -3013 +3013 @@
 
     if (code < 200)
-        code = PJSIP_SC_OK;
+        code = PJSIP_SC_ACCEPTED;
     if (code >= 300) {
         /* Application rejects call transfer request */
@@ -3028 +3028 @@
     if (no_refer_sub) {
         /*
-         * Always answer with 200.
+         * Always answer with 2xx.
          */
         pjsip_tx_data *tdata;
@@ -3034 +3034 @@
         pjsip_hdr *hdr;
 
-        status = pjsip_dlg_create_response(inv->dlg, rdata, 200, NULL, &tdata);
+        status = pjsip_dlg_create_response(inv->dlg, rdata, code, NULL, 
+                                           &tdata);
         if (status != PJ_SUCCESS) {
-            pjsua_perror(THIS_FILE, "Unable to create 200 response to REFER",
+            pjsua_perror(THIS_FILE, "Unable to create 2xx response to REFER",
                          status);
             return;
@@ -3052 +3053 @@
                                          tdata);
         if (status != PJ_SUCCESS) {
-            pjsua_perror(THIS_FILE, "Unable to create 200 response to REFER",
+            pjsua_perror(THIS_FILE, "Unable to create 2xx response to REFER",
                          status);
             return;
@@ -3094 +3095 @@
         }
 
-        /* Accept the REFER request, send 200 (OK). */
+        /* Accept the REFER request, send 2xx. */
         pjsip_xfer_accept(sub, rdata, code, &hdr_list);